fixed epoch_interruption on new wasm instance creation #89
Conversation
|
|
||
| let lind_manager = child_ctx.lind_manager.clone(); | ||
| let mut store = Store::new_with_inner(&engine, child_host, store_inner); | ||
| store.set_epoch_deadline(1); |
There was a problem hiding this comment.
add a one line comment here about what this is doing
There was a problem hiding this comment.
these comments don't really explain why we would do this or what this is
| let instance_pre = Arc::new(child_ctx.linker.instantiate_pre(&child_ctx.module).unwrap()); | ||
|
|
||
| let mut store = Store::new_with_inner(&engine, child_host, store_inner); | ||
| store.set_epoch_deadline(1); |
| self.inner.epoch.fetch_add(1, Ordering::Relaxed); | ||
| } | ||
|
|
||
| pub fn decrement_epoch(&self) { |
| thread::sleep(timeout); | ||
| engine.increment_epoch(); | ||
| }); | ||
| } else if self.run.common.wasm.epoch_interruption.is_some() { |
| self.inner.set_epoch_deadline(ticks_beyond_current); | ||
| } | ||
|
|
||
| // get current epoch deadline |
There was a problem hiding this comment.
This comment seems to just restate the function name in comment form, is there more information we can provide here?
|
@qianxichen233 are we abandoning this PR due to other changes for signals? |
Yes, we are no longer using wasmtime's built-in epoch mechanism |
Ok cool. I'm going to close this. Feel free to close PR's that we dont plan on merging in the future. |
A very minor PR. Fixed this issue by initializing epoch when new wasm instance is created.
This is the initial integration of epoch_interruption into lind's architecture. We plan to use epoch_interruption to implement several features (thread cancelation feature and signal implementation), so having a basic epoch_interruption working here is a good start.
Epoch is an u64 variable and we can use it as an integer if we want. But currently we only need to use epoch has a way to interrupt the wasm process, it is sufficient to just use 0 and 1 on epoch to represent
normalandinterruptedrespectively. So I am setting epoch deadline to be always 1 here.